fix: truncating caldav subscription data before saving on DB - #63295
Open
madbob wants to merge 1 commit into
Open
fix: truncating caldav subscription data before saving on DB#63295madbob wants to merge 1 commit into
madbob wants to merge 1 commit into
Conversation
madbob
requested review from
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
August 15, 2026 17:03
solracsf
added
3. to review
Signed-off-by: Roberto Guido <info@madbob.org>
SebastianKrupinski
approved these changes
Aug 16, 2026
SebastianKrupinski
left a comment
SebastianKrupinski
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
$subscriptionPropertyMapI've added, for "string" properties, the maximum length, to know how to properly truncate incoming values.Note: I've found that in
$subscriptionPropertyMaparray bothstripalarmsandstripattachmentswere marked as "string", since the introduction of those datatypes. But in database schema those are always been "smallint" (boolean) values.Checklist
3. to review, feature component)stable32)